Rework CustomJWTAuthentication to request the oauth token correctly #465
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usecase:
I am using oidc on k8s with workload-identity for spark applications and noticed that requesting a token did not work.
Problem:
The fix for #437 is not sufficient to work with workload identity as the new CustomJwtAuthentication class does not construct the correct body for requesting a token (the applyTo method does nothing).
I use this library as follows:
Changes that I made are:
Note on running all tests:
I had issues running all tests as some depended on libraries I do not have on Linux. To test the relevant classes I created a custom keystore with a self signed certificate in it with a password (minimum was 6 characters). Can you describe the setup required to run all the tests locally?