Merge pull request #1771 from AzureAD/msal-common-unifiedCache-update

[msal-common][msal-node][#4] Update UnifiedCacheManager.ts
AzureAD · Jun 18, 2020 · 25d53da · 25d53da
2 parents d7675e0 + db09f5e
commit 25d53da
Show file tree

Hide file tree

Showing 49 changed files with 1,123 additions and 1,440 deletions.
diff --git a/lib/msal-browser/src/app/PublicClientApplication.ts b/lib/msal-browser/src/app/PublicClientApplication.ts
@@ -530,7 +530,7 @@ export class PublicClientApplication {
      * @returns {@link IAccount[]} - Array of account objects in cache
      */
     public getAllAccounts(): IAccount[] {
-        return this.authModule.getAllAccounts();
+        return this.browserStorage.getAllAccounts();
     }
 
     /**

diff --git a/lib/msal-browser/src/cache/BrowserStorage.ts b/lib/msal-browser/src/cache/BrowserStorage.ts
@@ -2,7 +2,7 @@
  * Copyright (c) Microsoft Corporation. All rights reserved.
  * Licensed under the MIT License.
  */
-import { ICacheStorage, Constants, PersistentCacheKeys, StringUtils, AuthorizationCodeRequest, ICrypto, CacheSchemaType, AccountEntity, IdTokenEntity, CacheHelper, CredentialType, AccessTokenEntity, RefreshTokenEntity, AppMetadataEntity } from "@azure/msal-common";
+import { Constants, PersistentCacheKeys, StringUtils, AuthorizationCodeRequest, ICrypto, CacheSchemaType, AccountEntity, IdTokenEntity, CacheHelper, CredentialType, AccessTokenEntity, RefreshTokenEntity, AppMetadataEntity, CacheManager } from "@azure/msal-common";
 import { CacheOptions } from "../config/Configuration";
 import { BrowserAuthError } from "../error/BrowserAuthError";
 import { BrowserConfigurationAuthError } from "../error/BrowserConfigurationAuthError";
@@ -16,7 +16,7 @@ const COOKIE_LIFE_MULTIPLIER = 24 * 60 * 60 * 1000;
  * Cookies are only used if storeAuthStateInCookie is true, and are only used for
  * parameters such as state and nonce, generally.
  */
-export class BrowserStorage implements ICacheStorage {
+export class BrowserStorage extends CacheManager {
 
     // Cache configuration, either set by user or default values.
     private cacheConfig: CacheOptions;
@@ -26,6 +26,7 @@ export class BrowserStorage implements ICacheStorage {
     private clientId: string;
 
     constructor(clientId: string, cacheConfig: CacheOptions) {
+        super();
         // Validate cache location
         this.validateWindowStorage(cacheConfig.cacheLocation);