Wrap entire top and left popup position calculations with Math.max in…

…stead of just wrapping the offset
AzureAD · Jul 16, 2020 · b4abe08 · b4abe08
1 parent 1708874
commit b4abe08
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/msal-browser/src/interaction_handler/PopupHandler.ts b/lib/msal-browser/src/interaction_handler/PopupHandler.ts
@@ -126,8 +126,8 @@ export class PopupHandler extends InteractionHandler {
              */
             const width = window.innerWidth || document.documentElement.clientWidth || document.body.clientWidth;
             const height = window.innerHeight || document.documentElement.clientHeight || document.body.clientHeight;
-            const left = ((width / 2) - (popUpWidth / 2)) + Math.max(0, winLeft);
-            const top = ((height / 2) - (popUpHeight / 2)) + Math.max(0, winTop);
+            const left = Math.max(0, ((width / 2) - (popUpWidth / 2)) + winLeft);
+            const top = Math.max(0, ((height / 2) - (popUpHeight / 2)) + winTop);
 
             // open the window
             const popupWindow = window.open(urlNavigate, title, "width=" + popUpWidth + ", height=" + popUpHeight + ", top=" + top + ", left=" + left);