Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msal-common supports sub-error codes #1348

Closed
jmckennon opened this issue Mar 4, 2020 · 0 comments · Fixed by #1533
Closed

msal-common supports sub-error codes #1348

jmckennon opened this issue Mar 4, 2020 · 0 comments · Fixed by #1533
Assignees
@tnorling @jmckennon
Labels
internal Issues created by MSAL.js team for internal tracking.
Milestone
April 2020

Comments

@jmckennon
Copy link
Contributor

jmckennon commented Mar 4, 2020 •
edited

Previous issue: #903. We found this was not applicable to msal-core and the implicit flow, but will be implemented in msal-common and the auth-code flow. These are detailed further on #903. They should be passed through to users of the msal client with errors when applicable.

The .NET team has an implementation that can be used as prior art.

This is the mapping of errors from ESTS. You can ctrl+f to find relevant ones.

To reproduce example suberrors, use the conditional access labs accounts. For example, these can reproduce a consent_required error that comes with a sub-error.
@jmckennon jmckennon added the internal Issues created by MSAL.js team for internal tracking. label Mar 4, 2020
@jmckennon jmckennon added this to the March 2020 milestone Mar 4, 2020
@jmckennon jmckennon self-assigned this Mar 4, 2020
@jmckennon jmckennon mentioned this issue Apr 1, 2020
Closed
5 tasks
@sameerag sameerag mentioned this issue Apr 10, 2020
Closed
3 tasks
@tnorling tnorling self-assigned this Apr 10, 2020
@jasonnutter jasonnutter modified the milestones: March 2020, April 2020 Apr 16, 2020
@tnorling tnorling mentioned this issue Apr 22, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tnorling tnorling

@jmckennon jmckennon

Labels
internal Issues created by MSAL.js team for internal tracking.
Projects
None yet
Milestone
April 2020
3 participants
@jasonnutter @tnorling @jmckennon