[msal-common][msal-browser] Add support for sub error codes #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…soft-authentication-library-for-js into msal-common-sub-errors
…tion-library-for-js into msal-common-sub-errors
jasonnutter
suggested changes
Apr 28, 2020
| static isInteractionRequiredError(errorCode: string, errorString: string, subError?: string) : boolean { | ||
| const isInteractionRequiredErrorCode = !StringUtils.isEmpty(errorCode) && Object.values(InteractionRequiredAuthErrorMessage).includes(errorCode); | ||
| const isInteractionRequiredSubError = !StringUtils.isEmpty(subError) && Object.values(InteractionRequiredAuthSubErrorMessage).includes(subError); | ||
| const isInteractionRequiredErrorDesc = !StringUtils.isEmpty(errorString) && Object.values(InteractionRequiredAuthErrorMessage).some((irErrorCode) => { |
There was a problem hiding this comment.
Object.values is not supported in IE: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/values
I'm not sure if Typescript provides a polyfill, can you check to see if this works in IE11?
There was a problem hiding this comment.
Good to know. Will look into it.
tnorling
commented
Apr 28, 2020
pkanher617
approved these changes
May 5, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #1451 and will close #1348
It adds support for sub-error codes returned from the /token endpoint indicating that interaction is required