Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[msal-node] Remove default scopes from refresh and silent flows #1979

Closed
1 of 8 tasks
pkanher617 opened this issue Jul 16, 2020 · 2 comments
Closed
1 of 8 tasks

[msal-node] Remove default scopes from refresh and silent flows #1979

pkanher617 opened this issue Jul 16, 2020 · 2 comments
Labels
internal Issues created by MSAL.js team for internal tracking.

Comments

@pkanher617
Copy link
Contributor

Please follow the issue template below.

Library

  • msal@1.x.x or @azure/msal@1.x.x
  • @azure/msal-browser@2.x.x
  • @azure/msal-angular@0.x.x
  • @azure/msal-angular@1.x.x
  • @azure/msal-angularjs@1.x.x

Upcoming Library

  • @azure/msal-node@1.x

Source

  • Internal (MSAL.js team)
  • Customer request

Description

We have removed adding default scopes from acquireTokenSilent in the msal-browser package to ensure that we don't have any cache misses. msal-node should follow the same model to ensure that we don't go to the wire when we don't need to.

Priority

Medium

Acceptance Criteria

msal-node handles the scenario where non-graph resource scopes are sent together and cause a cache miss because of default scopes.
@pkanher617 pkanher617 added the internal Issues created by MSAL.js team for internal tracking. label Jul 16, 2020
@pkanher617
Copy link
Contributor Author

Refer to #1962 for msal-browser changes.

@tnorling
Copy link
Collaborator

Closing per #2267 all network calls should request default scopes

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
internal Issues created by MSAL.js team for internal tracking.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tnorling @pkanher617