Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default scopes to silent requests #2267

Merged
merged 10 commits into from Sep 14, 2020
Merged

Conversation

tnorling
Copy link
Collaborator

@tnorling tnorling commented Sep 10, 2020

  • Adds openid and profile to all requests during parameter builder step. eSTS expects that these scopes are present on all requests.
  • Removes these scopes from the cache lookup logic to prevent cache misses if the service does not return these scopes in the response.
  • Removes these scopes from intersecting scope logic to prevent possible unintended removal of tokens that contain these scopes.

@github-actions github-actions bot added msal-browser Related to msal-browser package msal-common Related to msal-common package labels Sep 10, 2020
@coveralls
Copy link

coveralls commented Sep 10, 2020

Coverage Status

Coverage increased (+0.08%) to 83.325% when pulling 92ea914 on default-scopes-silent-calls into 75521b5 on dev.

Copy link
Contributor

@pkanher617 pkanher617 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Make sure we add/update tests before we merge.

Copy link
Collaborator

@jo-arroyo jo-arroyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tnorling tnorling merged commit d1b306f into dev Sep 14, 2020
@tnorling tnorling deleted the default-scopes-silent-calls branch September 29, 2020 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
msal-browser Related to msal-browser package msal-common Related to msal-common package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants