Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme.md for msal-node states that the confidential client supports username and password flow #3858

Closed
larskaare opened this issue Jul 13, 2021 · 3 comments · Fixed by #3838
Closed

Readme.md for msal-node states that the confidential client supports username and password flow #3858

larskaare opened this issue Jul 13, 2021 · 3 comments · Fixed by #3838
Assignees
@jasonnutter
Labels
answered Question has received "first qualified response" bug-unconfirmed A reported bug that needs to be investigated and confirmed msal-node Related to msal-node package msal-node-extensions Related to msal-node-extensions package question Customer is asking for a clarification, use case or information.

Comments

@larskaare
Copy link

Core Library

MSAL Node (@azure/msal-node)

Core Library Version

4.3.0

Wrapper Library

MSAL Node Extensions (@azure/msal-node-extensions)

Wrapper Library Version

1.1.0

Description

The readme.md file for msal-node states that the confidential client support the username and password flow.

(https://github.com/AzureAD/microsoft-authentication-library-for-js/tree/dev/lib/msal-node#confidential-client)

The support for this would be very nice for testing purposes, but either the readme file is wrong or I am missing something?

Error Message

No response

Msal Logs

No response

MSAL Configuration

.

Relevant Code Snippets

.

Reproduction Steps

.

Expected Behavior

.

Identity Provider

Azure AD / MSA

Browsers Affected (Select all that apply)

None (Server)

Regression

No response

Source

External (Customer)
@larskaare larskaare added bug-unconfirmed A reported bug that needs to be investigated and confirmed question Customer is asking for a clarification, use case or information. labels Jul 13, 2021
@ghost ghost assigned jasonnutter Jul 13, 2021
@ghost ghost added the Needs: Attention 👋 Awaiting response from the MSAL.js team label Jul 13, 2021
@github-actions github-actions bot added msal-node Related to msal-node package msal-node-extensions Related to msal-node-extensions package labels Jul 13, 2021
@jasonnutter
Copy link
Contributor

@larskaare Apologies for the confusion. Support for this is currently in PR review: #3838

@ghost ghost added answered Question has received "first qualified response" Needs: Author Feedback Awaiting response from issue author and removed Needs: Attention 👋 Awaiting response from the MSAL.js team labels Jul 13, 2021
@jasonnutter jasonnutter linked a pull request Jul 13, 2021 that will close this issue
ROPC added for confidential clients #3838
Merged
@larskaare
Copy link
Author

Ok,no problem @jasonnutter Any ETA for when this will be available?

@ghost ghost added Needs: Attention 👋 Awaiting response from the MSAL.js team and removed Needs: Author Feedback Awaiting response from issue author labels Jul 13, 2021
@ghost ghost removed the Needs: Attention 👋 Awaiting response from the MSAL.js team label Jul 13, 2021
@sameerag
Copy link
Member

@larskaare This is merged now and we plan to make a release early next week for msal-node.

@ghost ghost locked as resolved and limited conversation to collaborators Jul 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jasonnutter jasonnutter

Labels
answered Question has received "first qualified response" bug-unconfirmed A reported bug that needs to be investigated and confirmed msal-node Related to msal-node package msal-node-extensions Related to msal-node-extensions package question Customer is asking for a clarification, use case or information.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ROPC added for confidential clients AzureAD/microsoft-authentication-library-for-js
3 participants
@jasonnutter @larskaare @sameerag