Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROPC added for confidential clients #3838

Merged
merged 11 commits into from
Jul 13, 2021
Merged

ROPC added for confidential clients #3838

merged 11 commits into from
Jul 13, 2021

Conversation

sameerag
Copy link
Member

@sameerag sameerag commented Jul 7, 2021 •
edited
Loading

Add ROPC support for Confidential Client Applications.

@github-actions github-actions bot added the msal-node Related to msal-node package label Jul 7, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2021 •
edited
Loading

Codecov Report

Merging #3838 (c467d18) into dev (b154798) will decrease coverage by 0.16%.
The diff coverage is 75.00%.

Flag Coverage Δ *Carryforward flag
msal-angular 95.81% <ø> (ø)
msal-browser 85.05% <ø> (ø)
msal-common 85.28% <50.00%> (-0.03%) ⬇️
msal-core 73.02% <ø> (-2.07%) ⬇️ Carriedforward from be3f7bd
msal-node 83.55% <80.00%> (+1.02%) ⬆️
msal-react 94.11% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ib/msal-node/src/client/PublicClientApplication.ts 87.50% <ø> (+29.80%) ⬆️
...b/msal-common/src/client/UsernamePasswordClient.ts 88.63% <50.00%> (-1.84%) ⬇️
lib/msal-node/src/client/ClientApplication.ts 75.25% <80.00%> (+0.54%) ⬆️
lib/msal-core/src/error/ServerError.ts
lib/msal-core/src/error/AuthError.ts
lib/msal-core/src/packageMetadata.ts
...ib/msal-core/src/error/ClientConfigurationError.ts
lib/msal-core/src/utils/Constants.ts
lib/msal-core/src/authority/AuthorityFactory.ts
lib/msal-core/src/utils/TimeUtils.ts
... and 5 more

@sameerag sameerag marked this pull request as ready for review July 7, 2021 16:07
jasonnutter
jasonnutter approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@jasonnutter jasonnutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, any docs or samples that could be updated?

@jasonnutter jasonnutter added this to the @azure/msal-node@1.3.0 milestone Jul 7, 2021
@sameerag
Copy link
Member Author

sameerag commented Jul 7, 2021

Looks good, any docs or samples that could be updated?

Yes. Working on a sample update and a few docs, will add in sometime.

@sameerag sameerag requested a review from pkanher617 as a code owner July 9, 2021 22:43
@github-actions github-actions bot added msal-common Related to msal-common package samples Related to the samples apps for the library. labels Jul 9, 2021
pkanher617
pkanher617 approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@pkanher617 pkanher617 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should make sure we update the relevant docs inside the repo, as well as on docs.microsoft.com

@sameerag
Copy link
Member Author

Should make sure we update the relevant docs inside the repo, as well as on docs.microsoft.com

I checked and docs are already up to date. We do not add any docs in MSAL JS, but redirect it to docs.microsoft.com and we do mention that it is supported for both public and confidential clients.

samuelkubai
samuelkubai approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@samuelkubai samuelkubai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasonnutter jasonnutter mentioned this pull request Jul 13, 2021
Closed
@jasonnutter jasonnutter linked an issue Jul 13, 2021 that may be closed by this pull request
Readme.md for msal-node states that the confidential client supports username and password flow #3858
Closed
@sameerag sameerag merged commit 15b7652 into dev Jul 13, 2021
@sameerag sameerag deleted the ropc-cca-support branch July 13, 2021 16:09
@jasonnutter jasonnutter linked an issue Jul 19, 2021 that may be closed by this pull request
Automated tests can obtain token using clientId/secret but MSAL.clientInfo is null #3861
Closed
@ghost
Copy link

ghost commented Jul 22, 2021

🎉@azure/msal-node@v1.3.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jul 22, 2021

🎉@azure/msal-common@v4.5.0 has been released which incorporates this pull request.:tada:

We recommend upgrading to the latest version of @azure/msal-browser or @azure/msal-node to take advantage of this change.

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonnutter jasonnutter jasonnutter approved these changes

@tnorling tnorling tnorling left review comments

@pkanher617 pkanher617 pkanher617 approved these changes

@samuelkubai samuelkubai samuelkubai approved these changes

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

Assignees
No one assigned
Labels
msal-common Related to msal-common package msal-node Related to msal-node package samples Related to the samples apps for the library.
Projects
None yet
Milestone
@azure/msal-node@1.3.0
6 participants
@sameerag @codecov-commenter @jasonnutter @tnorling @pkanher617 @samuelkubai