Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how should I pass additional parameters to the ADFS login service via AAD authority #6265

Closed
GHL2770 opened this issue Jul 26, 2023 · 5 comments
Assignees
Labels
msal-node Related to msal-node package msal-react Related to @azure/msal-react Needs: Author Feedback Awaiting response from issue author no-issue-activity Issue author has not responded in 5 days public-client Issues regarding PublicClientApplications question Customer is asking for a clarification, use case or information.

Comments

@GHL2770
Copy link

GHL2770 commented Jul 26, 2023

Core Library

MSAL Node (@azure/msal-node)

Core Library Version

1.18.0

Wrapper Library

MSAL React (@azure/msal-react)

Wrapper Library Version

None

Public or Confidential Client?

Public

Description

Verify the AAD+ADFS login using the official MSAL.JS sample code (https://github.com/AzureAD/microsoft-authentication-library-for-js/tree/dev/samples/msal-react-samples/react-router-sample ), specifying extraQueryParameters: {"OTP": "123456"}, which is passed to AAD authority, but AAD is not passed to ADFS authority; But when we point authority directly to ADFS authority, the ADFS login service can receive additional parameters specified by extraQueryParameters.
Please confirm whether AAD authentication supports passing additional parameters to ADFS.
If possible, how should I pass additional parameters to the ADFS login service via AAD authority?

MSAL Configuration

No response

Relevant Code Snippets

No response

Identity Provider

Azure AD / MSA

Source

Internal (Microsoft)

@GHL2770 GHL2770 added the question Customer is asking for a clarification, use case or information. label Jul 26, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Awaiting response from the MSAL.js team label Jul 26, 2023
@github-actions github-actions bot added msal-node Related to msal-node package msal-react Related to @azure/msal-react public-client Issues regarding PublicClientApplications labels Jul 26, 2023
@sameerag
Copy link
Member

@GHL2770 Are these params to be added to the /authorize end point or the /token endpoint?

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Author Feedback Awaiting response from issue author and removed Needs: Attention 👋 Awaiting response from the MSAL.js team labels Jul 26, 2023
@GHL2770
Copy link
Author

GHL2770 commented Jul 27, 2023

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Awaiting response from the MSAL.js team and removed Needs: Author Feedback Awaiting response from issue author labels Jul 27, 2023
@GHL2770
Copy link
Author

GHL2770 commented Jul 27, 2023

image
I added an extra parameter to the request for AAD authentication, extraQueryParameters: {"OTP": "123456"}, You can see in the AAD https://login.partner.microsoftonline.cn/ * * * * / oauth2 authentication/v2.0 "OTP=1234568**" are included in the GET request, but the location to have the adfs have no this parameter.

@sameerag
Copy link
Member

@GHL2770 The AAD->ADFS interface is controlled by the service and not MSAL JS. I can reroute this question to the STS folks and get back.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Author Feedback Awaiting response from issue author and removed Needs: Attention 👋 Awaiting response from the MSAL.js team labels Jul 27, 2023
@microsoft-github-policy-service
Copy link
Contributor

@GHL2770 This issue has been automatically marked as stale because it is marked as requiring author feedback but has not had any activity for 5 days. If your issue has been resolved please let us know by closing the issue. If your issue has not been resolved please leave a comment to keep this open. It will be closed automatically in 7 days if it remains stale.

@microsoft-github-policy-service microsoft-github-policy-service bot added the no-issue-activity Issue author has not responded in 5 days label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
msal-node Related to msal-node package msal-react Related to @azure/msal-react Needs: Author Feedback Awaiting response from issue author no-issue-activity Issue author has not responded in 5 days public-client Issues regarding PublicClientApplications question Customer is asking for a clarification, use case or information.
Projects
None yet
Development

No branches or pull requests

2 participants