Authorization Code Flow for Single Page Applications: Authority and Protocol Classes #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkanher617
assigned jasonnutter, DarylThayil, jmckennon, sameerag and pkanher617 and unassigned jasonnutter, DarylThayil, jmckennon and sameerag
pkanher617
requested review from
DarylThayil,
jasonnutter,
sameerag and
jmckennon
DarylThayil
reviewed
Nov 26, 2019
| } | ||
|
|
||
| constructor(rawClientInfo: string, crypto: ICrypto) { | ||
| if (!rawClientInfo || StringUtils.isEmpty(rawClientInfo)) { |
There was a problem hiding this comment.
are there times there are empty client info and we want to construct the class?
There was a problem hiding this comment.
I believe there are cases in B2C where we may not receive the client info object, but I will double check to verify. It would probably be a better pattern to throw a warning and not create the object at all, so I will make some changes to reflect that.
There was a problem hiding this comment.
Updated, please re-review
There was a problem hiding this comment.
Some cases of device flow had this issue but eSTS guarantees client_info and if it is empty, we need to raise a bug against them. However it may be necessary to confirm the expected behavior from msal js in case it returns empty.
DarylThayil
reviewed
Nov 26, 2019
DarylThayil
reviewed
Nov 26, 2019
DarylThayil
reviewed
Nov 26, 2019
DarylThayil
reviewed
Nov 26, 2019
DarylThayil
reviewed
Nov 26, 2019
jasonnutter
reviewed
Nov 26, 2019
jmckennon
reviewed
Nov 26, 2019
jasonnutter
reviewed
Nov 27, 2019
pkanher617
commented
Nov 27, 2019
sameerag
reviewed
Dec 3, 2019
sameerag
reviewed
Dec 3, 2019
sameerag
reviewed
Dec 3, 2019
sameerag
reviewed
Dec 3, 2019
sameerag
reviewed
Dec 3, 2019
pkanher617
commented
Dec 3, 2019
pkanher617
commented
Dec 3, 2019
pkanher617
commented
Dec 3, 2019
pkanher617
changed the base branch from
authorization-code-flow-api
to
authorization-code-flow-base
added 2 commits
December 4, 2019 11:00
sameerag
approved these changes
Dec 5, 2019
azure-pipelines bot
pushed a commit
to pkanher617/microsoft-authentication-library-for-js
that referenced
this pull request
Jan 4, 2022
…auth-classes Authorization Code Flow for Single Page Applications: Authority and Protocol Classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review PR #1109 before this one.
This PR adds authority and protocol-specific classes to the Authorization Code Flow library. Any changes to the account, IdToken, client info or authority classes should be incorporated in this PR. Most of these classes have been lifted from the implicit flow library, and should be thoroughly reviewed before merging.