Authorization Code Flow for Single Page Applications: Implementation of the Fetch Client in the Browser #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkanher617
requested review from
jasonnutter,
DarylThayil,
jmckennon and
sameerag
pkanher617
changed the title
jasonnutter
suggested changes
Dec 5, 2019
…ion-code-flow-browser-fetch
…ion-code-flow-browser-fetch
…ion-code-flow-browser-fetch
pkanher617
commented
Dec 6, 2019
jasonnutter
reviewed
Dec 6, 2019
added 2 commits
December 9, 2019 13:58
…ion-code-flow-browser-fetch
jmckennon
approved these changes
Dec 9, 2019
jasonnutter
suggested changes
Dec 10, 2019
added 4 commits
December 10, 2019 13:20
…ion-code-flow-browser-fetch
…ion-code-flow-browser-fetch
sameerag
approved these changes
Dec 10, 2019
jasonnutter
reviewed
Dec 11, 2019
| * @param headers | ||
| * @param body | ||
| */ | ||
| async sendGetRequestAsync<T>(url: string, options?: NetworkRequestOptions): Promise<T> { |
jasonnutter
reviewed
Dec 11, 2019
| } | ||
|
|
||
| async sendPostRequestAsync<T>(url: string, options?: NetworkRequestOptions): Promise<T> { | ||
| return this.sendRequestAsync(url, "POST", options); |
There was a problem hiding this comment.
Can we use the enum here also?
There was a problem hiding this comment.
Updated in PR #1149.
jasonnutter
reviewed
Dec 12, 2019
pkanher617
changed the base branch from
authorization-code-flow-browser-crypto
to
authorization-code-flow-base
azure-pipelines bot
pushed a commit
to pkanher617/microsoft-authentication-library-for-js
that referenced
this pull request
Jan 4, 2022
…browser-fetch Authorization Code Flow for Single Page Applications: Implementation of the Fetch Client in the Browser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the fetch client for asynchronous network requests in the browser library for MSAL.js. This network client will be used for endpoint discovery and code-token exchange.
Please review PR #1140 before this PR.