Authorization Code Flow for Single Page Applications: Adding Logger class #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkanher617
requested review from
jasonnutter,
jmckennon,
sameerag and
DarylThayil
jasonnutter
reviewed
Dec 13, 2019
jasonnutter
suggested changes
Dec 16, 2019
jasonnutter
approved these changes
Dec 18, 2019
| this.logMessage(message, { | ||
| logLevel: LogLevel.Error, | ||
| containsPii: false, | ||
| correlationId: correlationId || "" |
There was a problem hiding this comment.
Is correlationId used? And I would argue to have this fallback logic to empty string inside of logMessage, so that you don't have to do it in each log level function.
pkanher617
changed the base branch from
authorization-code-flow-login-url
to
authorization-code-flow-base
azure-pipelines bot
pushed a commit
to pkanher617/microsoft-authentication-library-for-js
that referenced
this pull request
Jan 4, 2022
…logger Authorization Code Flow for Single Page Applications: Adding Logger class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a logger class to the Authorization Code Flow version of the MSAL library. It also removes instances of console.log from the common package.