Authorization Code Flow for Single Page Applications: Silent Flow and Logout #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-code-flow-silentHandler
…n-code-flow-silentHandler
pkanher617
requested review from
jasonnutter,
DarylThayil,
jmckennon and
sameerag
|
General comment: seems like these could be separate PRs, and theres seemingly other unrelated scope creep (e.g. validation in redirect methods). |
jasonnutter
suggested changes
Jan 14, 2020
…n-code-flow-silentHandler
jmckennon
reviewed
Jan 15, 2020
jasonnutter
reviewed
Jan 15, 2020
jasonnutter
approved these changes
Jan 15, 2020
pkanher617
changed the base branch from
authorization-code-flow-popupHandler
to
authorization-code-flow-base
jmckennon
approved these changes
Jan 17, 2020
sameerag
reviewed
Jan 17, 2020
| export type SystemOptions = { | ||
| loggerOptions?: BrowserLoggerOptions; | ||
| export type BrowserSystemOptions = SystemOptions & { | ||
| loggerOptions?: LoggerOptions; |
There was a problem hiding this comment.
nitpick: Overwrites a generic loggerOptions object? If it is browser specific, the name is very generic. I will check the code as a whole later, this is for traction.
There was a problem hiding this comment.
Logger isn't browser specific, only the implementation is, so I reverted back to generic logger options.
azure-pipelines bot
pushed a commit
to pkanher617/microsoft-authentication-library-for-js
that referenced
this pull request
Jan 4, 2022
…silentHandler Authorization Code Flow for Single Page Applications: Silent Flow and Logout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the silent flow and logout to the library. The implementation of ADAL SSO and other SSO features is included in a later PR.
This PR also enables CSP in our sample applications. This improves the security of our samples, and should be included in documentation moving forward.