Authorization Code Flow for Single Page Applications: Cleanup Popup Flows and Window Nav #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkanher617
requested review from
jasonnutter,
DarylThayil,
jmckennon and
sameerag
jmckennon
reviewed
Jan 23, 2020
jmckennon
approved these changes
Jan 24, 2020
DarylThayil
approved these changes
Jan 27, 2020
jasonnutter
suggested changes
Jan 27, 2020
sameerag
approved these changes
Jan 28, 2020
azure-pipelines bot
pushed a commit
to pkanher617/microsoft-authentication-library-for-js
that referenced
this pull request
Jan 4, 2022
…cleanupPopup-flows Authorization Code Flow for Single Page Applications: Cleanup Popup Flows and Window Nav
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds cleanup for different popup related errors, as well as window navigation actions such as redirect and refresh. This does not affect token acquisition, but does force users to be aware that handleRedirectCallback() should not be used with the popup APIs, as it will cause the window to handle the response in the popup, rather than the main window.
This should fix the issue raised in #1231.