Export Logger class from common and browser packages #1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkanher617
requested review from
jasonnutter,
sameerag,
tnorling,
sangonzal and
DarylThayil
tnorling
approved these changes
Apr 9, 2020
jasonnutter
reviewed
Apr 9, 2020
lib/msal-browser/src/index.ts
Outdated
| INetworkModule | ||
| INetworkModule, | ||
| // Logger Object | ||
| Logger |
There was a problem hiding this comment.
I think LogLevel should also be exported, in case someone wants to write logic based on that for each message.
jasonnutter
approved these changes
Apr 10, 2020
|
@sangonzal We should port this to msal-node-base I believe? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fix for the issue raised in #1469.
This adds the Logger object to the exported objects in the
index.tsfile.