handleRedirectCallback Updates for MSAL 2.0 #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameerag
reviewed
Apr 10, 2020
lib/msal-browser/package.json
Outdated
| @@ -40,7 +40,6 @@ | |||
| "doc": "npm run doc:generate && npm run doc:deploy", | |||
| "doc:generate": "typedoc --mode modules --excludePrivate --excludeProtected --out ./ref ./src/ --gitRevision dev", | |||
| "doc:deploy": "gh-pages -d ref -a -e ref/msal-browser", | |||
| "pretest": "npm link @azure/msal-common", | |||
There was a problem hiding this comment.
Not needed anymore since lerna bootstrap should take care of linking
tnorling
reviewed
Apr 10, 2020
|
Are we also planning to port the state changes Jason made in core? As those affect these pieces of code as well. |
sameerag
reviewed
Apr 19, 2020
| * | ||
| * To renew idToken, please pass clientId as the only scope in the Authentication Parameters. | ||
| * @returns {Promise.<TokenResponse>} - a promise that is fulfilled when this function has completed, or rejected if an error was raised. Returns the {@link AuthResponse} object | ||
| */ | ||
| async ssoSilent(request: AuthenticationParameters): Promise<TokenResponse> { | ||
| // block the reload if it occurred inside a hidden iframe | ||
| BrowserUtils.blockReloadInHiddenIframes(); |
There was a problem hiding this comment.
Why not add preFlightRequest() call here for uniformity? Even if interaction is false, it is in a conditional, so we should be good.
There was a problem hiding this comment.
I didn't want to add side effects if there were any. For now I will leave it as is, but I can update it if we find a reason for it.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the changes made in msal-core to the new version of the library in #1358.
navigateToLoginRequestUrl changes are already part of this codebase.