[msal-browser] Add pattern for login on page-load #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkanher617
requested review from
jasonnutter,
DarylThayil,
tnorling,
sameerag and
sangonzal
5 tasks
jasonnutter
suggested changes
Apr 24, 2020
jasonnutter
approved these changes
Apr 27, 2020
jasonnutter
reviewed
Apr 27, 2020
| @@ -106,6 +107,7 @@ export class PublicClientApplication { | |||
| * containing data from the server (returned with a null or non-blocking error). | |||
| */ | |||
| async handleRedirectCallback(authCallback: AuthCallback): Promise<void> { | |||
| console.warn("handleRedirectCallback will be deprecated upon release of msal-browser@v2.0.0. Please transition to using onRedirectAppLoad()."); | |||
There was a problem hiding this comment.
@pkanher617 Forgot to update the warning with the new API name :(
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue raised in #1497 where calling loginRedirect on page load will cause the application to go into a redirect loop.
This PR adds an API which allows applications using the redirect flow to utilize and notify their application that MSAL is done loading.