[msal-common] Fix caching for multiple resources #1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In general looks good can we add a test to validate different scope scenarios ? |
tnorling
requested review from
pkanher617,
sameerag,
jasonnutter,
sangonzal,
jo-arroyo,
DarylThayil and
hectormmg
jasonnutter
approved these changes
May 4, 2020
sameerag
reviewed
May 4, 2020
lib/msal-common/src/auth/ScopeSet.ts
Outdated
| const sizeThisScopes = this.containsScope(Constants.OFFLINE_ACCESS_SCOPE)? this.getScopeCount() - 1: this.getScopeCount(); | ||
| const sizeUnionScopes = unionScopes.has(Constants.OFFLINE_ACCESS_SCOPE)? unionScopes.size - 1: unionScopes.size; | ||
|
|
||
| return sizeUnionScopes < (sizeThisScopes + sizeOtherScopes); |
There was a problem hiding this comment.
Dumb q: Why are we checking count than content? What if count matches and content differs for the set? I may be missing some logic and will check. This is mostly a question I immediately had.
There was a problem hiding this comment.
unionScopes is a set of scope array 1 + scope array 2 containing only unique entries. If the size of this is less than the size of both arrays added together then you know there were shared scopes between the 2 individual arrays
There was a problem hiding this comment.
Size of both sets, not arrays. these are all unique values.
pkanher617
approved these changes
May 5, 2020
…tion-library-for-js into fix-multiple-resource-bug-2.0
…ureAD/microsoft-authentication-library-for-js into fix-multiple-resource-bug-2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
offline_accessscope was causing all scope sets to intersect, meaning all access tokens were being cached under the same entry with new scopes appended in the cache key. This PR aims to address this by ignoringoffline_accesswhen attempting to determine if we are adding or updating an access token in the cache.This will fix: #1487