Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend acquireTokenSilent Instrumentation #1629

Merged
merged 14 commits into from May 19, 2020
Merged

Extend acquireTokenSilent Instrumentation #1629

merged 14 commits into from May 19, 2020

Conversation

jo-arroyo
Copy link
Collaborator

@jo-arroyo jo-arroyo commented May 11, 2020 •
edited

This PR adds instrumentation through logger messages to acquireTokenSilent for msal-core.

@jo-arroyo jo-arroyo changed the title Add first log message to acquireTokenSilent Extend acquireTokenSilent Instrumentation May 11, 2020
@coveralls
Copy link

coveralls commented May 12, 2020 •
edited

Coverage Status

Coverage increased (+0.05%) to 81.211% when pulling 76381f7 on ats-instrumentation into c8c5ca2 on dev.

@jo-arroyo jo-arroyo marked this pull request as ready for review May 14, 2020 18:16
@jasonnutter jasonnutter added this to the msal@1.3.2 - Release milestone May 14, 2020
tnorling
tnorling approved these changes May 15, 2020
View reviewed changes
Copy link
Collaborator

@tnorling tnorling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple comments. Up to you if you want to update but overall looks good. Approving.

lib/msal-core/src/UserAgentApplication.ts Outdated Show resolved Hide resolved
lib/msal-core/src/UserAgentApplication.ts Outdated Show resolved Hide resolved
lib/msal-core/src/UserAgentApplication.ts Outdated Show resolved Hide resolved
hectormmg
hectormmg approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@hectormmg hectormmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jo-arroyo jo-arroyo merged commit ad1a86c into dev May 19, 2020
@jo-arroyo jo-arroyo deleted the ats-instrumentation branch June 8, 2020 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkanher617 pkanher617 pkanher617 approved these changes

@sameerag sameerag sameerag left review comments

@jasonnutter jasonnutter jasonnutter approved these changes

@hectormmg hectormmg hectormmg approved these changes

@tnorling tnorling tnorling approved these changes

@DarylThayil DarylThayil Awaiting requested review from DarylThayil

@sangonzal sangonzal Awaiting requested review from sangonzal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
msal@1.3.2 - Release
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jo-arroyo @coveralls @jasonnutter @hectormmg @tnorling @pkanher617 @sameerag