Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[msal-browser][msal-node][msal-common] Fix initialization of B2cTrustedHostList #1646

Merged
merged 7 commits into from May 13, 2020

Conversation

tnorling
Copy link
Collaborator

@tnorling tnorling commented May 12, 2020

With some of the recent changes we are no longer calling setKnownAuthorities in the correct place. This needs to be called before we create the authority instance. This PR ensures that happens for browser and node use cases.

@coveralls
Copy link

coveralls commented May 12, 2020

Coverage Status

Coverage remained the same at 81.062% when pulling d95c8de on fix-knownAuthorities-browser into 2b79a13 on dev.

Copy link
Contributor

@sangonzal sangonzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tnorling tnorling changed the title [msal-browser][msal-common] Fix setKnownAuthorities for browser [msal-browser][msal-node][msal-common] Fix initialization of B2cTrustedHostList May 13, 2020
@tnorling tnorling merged commit 71e140d into dev May 13, 2020
@tnorling tnorling deleted the fix-knownAuthorities-browser branch May 28, 2020 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants