[msal-node] Cache Lookup - 2: Save, lookup and delete entities #1655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameerag
commented
May 14, 2020
sangonzal
suggested changes
May 14, 2020
…arams and avoid null params
pkanher617
reviewed
May 27, 2020
pkanher617
reviewed
May 27, 2020
pkanher617
approved these changes
May 27, 2020
pkanher617
reviewed
May 27, 2020
jasonnutter
suggested changes
May 27, 2020
| if (matches) { | ||
| matchingCredentials[key] = cacheCredentials[key]; | ||
| } | ||
| }); |
There was a problem hiding this comment.
Same comment about using reduce instead of forEach.
In this use case I believe |
sangonzal
approved these changes
May 27, 2020
[msal-node] Cache Lookup - 3: Msal node cache response
sameerag
requested review from
DarylThayil,
jmckennon,
jo-arroyo,
hectormmg and
tnorling
as code owners
github-actions
bot
added
msal-browser
pkanher617
pushed a commit
to pkanher617/microsoft-authentication-library-for-js
that referenced
this pull request
Dec 30, 2021
…nterface [msal-node] Cache Lookup - 2: Save, lookup and delete entities
azure-pipelines bot
pushed a commit
to pkanher617/microsoft-authentication-library-for-js
that referenced
this pull request
Jan 4, 2022
…nterface [msal-node] Cache Lookup - 2: Save, lookup and delete entities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the functionality to save, lookup and delete cache entities. It defines the below helpers:
saveAccount()saveCredential()getAccount()getCredential()getAccountsFilteredBy()getCredentialsFilteredBy()removeAccount()removeCredential()Unit tests added.
Note: These helpers help support
silentandrefreshTokenflows in themsal-nodelibrary