[msal-node][#1] SilentFlow support in msal-common #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkanher617
reviewed
May 28, 2020
github-actions
bot
added
msal-browser
jasonnutter
reviewed
Jun 11, 2020
jasonnutter
reviewed
Jun 11, 2020
pkanher617
reviewed
Jun 11, 2020
pkanher617
reviewed
Jun 11, 2020
jasonnutter
suggested changes
Jun 11, 2020
sangonzal
reviewed
Jun 12, 2020
sangonzal
approved these changes
Jun 15, 2020
There was a problem hiding this comment.
Overall looks good. Some feedback from @jasonnutter looks relevant, chatted offline and agreed that it would be addressed in separate PR.
jasonnutter
approved these changes
Jun 17, 2020
This was referenced Jun 25, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for SilentFlow in
msal-commonThis unblocks the below use cases for the end user:
acquireTokenSilentfrommsal-browserandmsal-nodewhen the user has knowledge of the cachedaccountforceRefreshor if theaccessTokenhas expired, acquires a token withRefreshTokenFlow. This is achieved by calling the service with the cachedrefreshTokento acquire a new set of tokens.