Update CacheManager. Update auth code sample. #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sangonzal
requested review from
DarylThayil,
jasonnutter,
jmckennon,
jo-arroyo,
pkanher617,
sameerag,
hectormmg and
tnorling
as code owners
github-actions
bot
added
msal-common
sameerag
reviewed
Jun 5, 2020
| }); | ||
|
|
||
| return oldState; | ||
| } |
There was a problem hiding this comment.
Looks good. Can we add comments for readability?
sangonzal
commented
Jun 16, 2020
| @@ -1,8 +1,15 @@ | |||
| /* | |||
There was a problem hiding this comment.
I've split serialize/deserialize from writeToPersistence and readToPersistance, as that seemed much more transparent to me, but I'm happy to discuss/ change it back if want to do that.
DarylThayil
approved these changes
Jun 16, 2020
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.