Changing IAccount Interface to AccountInfo #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serializer needs to figure out how to implement swap and rename with strict type checks turned on.
pkanher617
requested review from
DarylThayil,
jasonnutter,
jmckennon,
jo-arroyo,
sameerag,
hectormmg and
tnorling
as code owners
github-actions
bot
added
msal-browser
sangonzal
approved these changes
Jun 17, 2020
| @@ -12,10 +13,11 @@ export class EntitySerializer { | |||
| * @param key | |||
| */ | |||
| static mapAccountKeys(accCache: AccountCache, key: string): object { | |||
There was a problem hiding this comment.
Some extra stuff in this file that I think is no longer needed (commented out)
There was a problem hiding this comment.
+1 for removing unneeded comments
There was a problem hiding this comment.
This is being fixed by @sameerag.
tnorling
requested changes
Jun 17, 2020
| @@ -12,10 +13,11 @@ export class EntitySerializer { | |||
| * @param key | |||
| */ | |||
| static mapAccountKeys(accCache: AccountCache, key: string): object { | |||
There was a problem hiding this comment.
+1 for removing unneeded comments
tnorling
approved these changes
Jun 18, 2020
tnorling
reviewed
Jun 19, 2020
…ureAD/microsoft-authentication-library-for-js into msal-common-account-interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the account object returned to the user from the IAccount interface to the AccountInfo type.
It also refactors the code to remove the CacheHelpers.ts file, and removes the
matcheslogic from the CacheManager.ts file.