[msal-browser][msal-common] Make library state an object and add timestamp (Updated) #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkanher617
requested review from
DarylThayil,
jasonnutter,
jmckennon,
jo-arroyo,
sameerag,
hectormmg and
tnorling
as code owners
github-actions
bot
added
msal-browser
tnorling
reviewed
Jun 17, 2020
jasonnutter
reviewed
Jun 18, 2020
jasonnutter
reviewed
Jun 18, 2020
jasonnutter
reviewed
Jun 18, 2020
jasonnutter
suggested changes
Jun 18, 2020
jasonnutter
approved these changes
Jun 22, 2020
tnorling
approved these changes
Jun 23, 2020
| @@ -932,7 +959,7 @@ describe("PublicClientApplication.ts Class Unit Tests", () => { | |||
| "tid": "3338040d-6c67-4c5b-b112-36a304b66dad", | |||
| "nonce": "123523", | |||
| }; | |||
| const testAccount: IAccount = { | |||
| const testAccount: AccountInfo = { | |||
There was a problem hiding this comment.
It looks like we recreate this testAccount in a lot of places. Can we just declare this at the top of the file or in a utils file once?
There was a problem hiding this comment.
Will optimize tests in a later PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an update of #1675, made because the cache update drastically changed the surface of the library. The changes made in this PR will be merged, and #1675 will be closed.
This PR converts library state from a GUID to a stringified JSON object with id and timestamp fields. This will allow msal-common and msal-browser to handle situations where responses are handled long after the request was initiated, and setting correct token expiration lifetimes.
Also includes tests.