Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a logout request object #1802

Merged
merged 10 commits into from Jun 24, 2020
Merged

Adding a logout request object #1802

merged 10 commits into from Jun 24, 2020

Conversation

pkanher617
Copy link
Contributor

This PR adds a logout request object to use during the logout call. Currently only used by msal-browser, may also be used by msal-node in the future.

@github-actions github-actions bot added msal-browser Related to msal-browser package msal-common Related to msal-common package labels Jun 19, 2020
jasonnutter
jasonnutter suggested changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@jasonnutter jasonnutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, also tests?

lib/msal-browser/src/app/PublicClientApplication.ts Outdated Show resolved Hide resolved
lib/msal-common/src/client/AuthorizationCodeClient.ts Show resolved Hide resolved
lib/msal-common/src/client/AuthorizationCodeClient.ts Outdated Show resolved Hide resolved
lib/msal-common/src/request/EndSessionRequest.ts Outdated Show resolved Hide resolved
jasonnutter
jasonnutter suggested changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@jasonnutter jasonnutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment.

lib/msal-browser/src/app/PublicClientApplication.ts Outdated Show resolved Hide resolved
lib/msal-browser/src/app/PublicClientApplication.ts Outdated Show resolved Hide resolved
lib/msal-browser/test/app/PublicClientApplication.spec.ts Outdated Show resolved Hide resolved
@pkanher617 pkanher617 changed the base branch from msal-common-client-merge to dev June 24, 2020 03:38
@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 79.031% when pulling 0f16a5a on logout-request into f7fa435 on dev.

@pkanher617 pkanher617 merged commit 610a3cd into dev Jun 24, 2020
@philtweir philtweir mentioned this pull request Jul 14, 2020
Closed
5 tasks
@s2ramana s2ramana mentioned this pull request Sep 24, 2020
Closed
@pkanher617 pkanher617 deleted the logout-request branch October 2, 2020 18:06
@stephenstroud
Copy link

Is this PR due out? I have a requirement where ID_TOKEN_HINT needs to be passed in for MSAL v1? Is this PR open to contribution?

@tnorling
Copy link
Collaborator

tnorling commented Oct 5, 2020

@stephenstroud This PR was released as part of version 2.0.0 but does not include functionality for providing id_token_hint. You can track issue #996 for that feature request, but it will likely not make it into version 1 at this point as new features are going into version 2.x moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonnutter jasonnutter jasonnutter requested changes

@tnorling tnorling tnorling approved these changes

@DarylThayil DarylThayil Awaiting requested review from DarylThayil

@jmckennon jmckennon Awaiting requested review from jmckennon

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

@sameerag sameerag Awaiting requested review from sameerag sameerag is a code owner

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

Assignees
No one assigned
Labels
msal-browser Related to msal-browser package msal-common Related to msal-common package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pkanher617 @coveralls @stephenstroud @tnorling @jasonnutter