New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[msal-browser] Fix encoding issues #1852
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but if state is (arbitrarily?) being double-encoded on the backend... shouldn't we look to get that fixed rather than double decode as well? Seems odd. What if they end up triple encoding something someday?
Agree with this. Should we maybe check for a certain property to know we're done decoding? |
Yes, we should get this fixed on the server, but for now, I think it is fine to assume things will at most be encoded twice. |
This PR fixes a couple issues
=
characters.decodeURIComponent
should fix those issues.