Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[msal-common] Fix issue where extraScopesToConsent was not appending scopes correctly #1854

Merged
merged 2 commits into from Jun 30, 2020
Merged

[msal-common] Fix issue where extraScopesToConsent was not appending scopes correctly #1854

merged 2 commits into from Jun 30, 2020

Conversation

pkanher617
Copy link
Contributor

This PR fixes an issue where scopes passed with extraScopesToConsent would not be added in a trimmed and lower-case format.

@pkanher617 pkanher617 changed the base branch from dev to fix-url-encoding-msal-browser June 29, 2020 20:41
@github-actions github-actions bot added the msal-common Related to msal-common package label Jun 29, 2020
@pkanher617 pkanher617 changed the base branch from fix-url-encoding-msal-browser to dev June 30, 2020 16:34
@coveralls
Copy link

coveralls commented Jun 30, 2020 •
edited

Coverage Status

Coverage decreased (-0.004%) to 79.246% when pulling 70d6ac3 on extrascopes-append-error-2.0 into bcc1ebf on dev.

@pkanher617 pkanher617 merged commit 39de7ad into dev Jun 30, 2020
@pkanher617 pkanher617 deleted the extrascopes-append-error-2.0 branch October 2, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonnutter jasonnutter jasonnutter approved these changes

@tnorling tnorling tnorling approved these changes

@DarylThayil DarylThayil Awaiting requested review from DarylThayil

@jmckennon jmckennon Awaiting requested review from jmckennon

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

@sameerag sameerag Awaiting requested review from sameerag sameerag is a code owner

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

Assignees
No one assigned
Labels
msal-common Related to msal-common package
Projects
None yet
Milestone
@azure/msal-browser@2.0.0 - GA Release
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pkanher617 @coveralls @jasonnutter @tnorling