Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update redirectUri and postLogoutRedirectUri #1861

Merged
merged 6 commits into from Jul 1, 2020
Merged

Update redirectUri and postLogoutRedirectUri #1861

merged 6 commits into from Jul 1, 2020

Conversation

tnorling
Copy link
Collaborator

@tnorling tnorling commented Jun 30, 2020 •
edited

  • redirectUri and postLogoutRedirectUri must be type string
  • redirectUri is optional on request object. If not provided, will take pca.config.auth.redirectUri or window.location.href

@github-actions github-actions bot added msal-browser Related to msal-browser package msal-common Related to msal-common package labels Jun 30, 2020
@coveralls
Copy link

coveralls commented Jun 30, 2020 •
edited

Coverage Status

Coverage decreased (-0.07%) to 79.427% when pulling 7b60dff on remove-redirectUri-function into c1ff9e1 on dev.

pkanher617
pkanher617 approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@pkanher617 pkanher617 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tnorling tnorling merged commit bd930f5 into dev Jul 1, 2020
@tnorling tnorling deleted the remove-redirectUri-function branch July 6, 2020 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonnutter jasonnutter jasonnutter approved these changes

@pkanher617 pkanher617 pkanher617 approved these changes

@DarylThayil DarylThayil Awaiting requested review from DarylThayil

@jmckennon jmckennon Awaiting requested review from jmckennon

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

@sameerag sameerag Awaiting requested review from sameerag sameerag is a code owner

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

Assignees
No one assigned
Labels
msal-browser Related to msal-browser package msal-common Related to msal-common package
Projects
None yet
Milestone
@azure/msal-browser@2.0.0 - GA Release
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tnorling @coveralls @jasonnutter @pkanher617