Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix redirection to pages with custom hashes or query params #1862

Merged
merged 14 commits into from Jul 2, 2020
Merged

Fix redirection to pages with custom hashes or query params #1862

merged 14 commits into from Jul 2, 2020

Conversation

tnorling
Copy link
Collaborator

@tnorling tnorling commented Jun 30, 2020 •
edited

  • Adds redirectStartPage to request object, enabling developers to specify a page other than redirectUri that they would like to end on after a loginRedirect or an acquireTokenRedirect
  • Fixes redirection/hash processing logic to enable returning to pages with custom hashes or query params

@github-actions github-actions bot added msal-browser Related to msal-browser package msal-common Related to msal-common package labels Jun 30, 2020
@coveralls
Copy link

coveralls commented Jun 30, 2020 •
edited

Coverage Status

Coverage increased (+0.1%) to 81.039% when pulling 2932e48 on loginStartPage into 7c40002 on dev.

pkanher617
pkanher617 suggested changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@pkanher617 pkanher617 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments/questions

jasonnutter
jasonnutter approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@jasonnutter jasonnutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small things otherwise looks good!

lib/msal-browser/src/app/PublicClientApplication.ts Outdated Show resolved Hide resolved
lib/msal-browser/src/app/PublicClientApplication.ts Outdated Show resolved Hide resolved
@tnorling tnorling mentioned this pull request Jul 1, 2020
Closed
1 task
DarylThayil
DarylThayil approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@DarylThayil DarylThayil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tnorling tnorling changed the base branch from dev to update-default-scopes-2.0 July 2, 2020 01:08
@pkanher617 pkanher617 changed the base branch from update-default-scopes-2.0 to dev July 2, 2020 18:05
pkanher617
pkanher617 approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@pkanher617 pkanher617 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on this, appreciate the attention to detail and testing. lgtm

@pkanher617 pkanher617 merged commit fa3c04a into dev Jul 2, 2020
@tnorling tnorling deleted the loginStartPage branch July 6, 2020 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonnutter jasonnutter jasonnutter approved these changes

@DarylThayil DarylThayil DarylThayil approved these changes

@pkanher617 pkanher617 pkanher617 approved these changes

@jmckennon jmckennon Awaiting requested review from jmckennon

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

@sameerag sameerag Awaiting requested review from sameerag sameerag is a code owner

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

Assignees
No one assigned
Labels
msal-browser Related to msal-browser package msal-common Related to msal-common package
Projects
None yet
Milestone
@azure/msal-browser@2.0.0 - GA Release
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tnorling @coveralls @jasonnutter @DarylThayil @pkanher617