Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IPublicClientApplication interface #1870

Merged
merged 1 commit into from Jul 1, 2020
Merged

Add IPublicClientApplication interface #1870

merged 1 commit into from Jul 1, 2020

Conversation

jasonnutter
Copy link
Contributor

@jasonnutter jasonnutter commented Jul 1, 2020 •
edited

Adds an IPublicClientApplication interface, properly documenting what the supported public API for PublicClientApplication will be.

@github-actions github-actions bot added the msal-browser Related to msal-browser package label Jul 1, 2020
@jasonnutter jasonnutter linked an issue Jul 1, 2020 that may be closed by this pull request
Add interface for PublicClientApplication #1743
Closed
8 tasks
@coveralls
Copy link

Coverage Status

Coverage remained the same at 79.458% when pulling 1a00ae9 on IPublicClientApplication into bc45975 on dev.

sameerag
sameerag approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@sameerag sameerag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pkanher617 pkanher617 merged commit 5317e74 into dev Jul 1, 2020
@tnorling tnorling deleted the IPublicClientApplication branch October 6, 2021 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarylThayil DarylThayil DarylThayil approved these changes

@pkanher617 pkanher617 pkanher617 approved these changes

@sameerag sameerag sameerag approved these changes

@jmckennon jmckennon Awaiting requested review from jmckennon

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

@tnorling tnorling Awaiting requested review from tnorling tnorling is a code owner

Assignees
No one assigned
Labels
msal-browser Related to msal-browser package
Projects
None yet
Milestone
@azure/msal-browser@2.0.0 - GA Release
Development

Successfully merging this pull request may close these issues.

Add interface for PublicClientApplication
5 participants
@jasonnutter @coveralls @DarylThayil @pkanher617 @sameerag