Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update msal-browser SilentHandler.monitorIframeForHash to be purely timing-based #1873

Merged
merged 4 commits into from Jul 2, 2020

Conversation

jasonnutter
Copy link
Contributor

@jasonnutter jasonnutter commented Jul 1, 2020

This PR updates the polling in SilentHandler to be purely timing-based, similar to #1823.

Other changes:

  • Renames SilentHandler method to monitorIframeForHash
  • Renames PopupHandler method to monitorPopupForHash
  • Removes urlNavigate from error message, as it contains PII (will be added back later in errorPii log statement).
  • Adds tests for both methods.

@coveralls
Copy link

coveralls commented Jul 1, 2020

Coverage Status

Coverage increased (+1.4%) to 80.834% when pulling fdf9609 on browser-monitoriframeforhash-monitorpopupforhash into d907a56 on dev.

Copy link
Contributor

@pkanher617 pkanher617 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 question but otherwise looks good

@github-actions github-actions bot added the msal@1.x Related to msal@1.x (implicit flow) label Jul 2, 2020
@jasonnutter jasonnutter merged commit cefe9e9 into dev Jul 2, 2020
@tnorling tnorling deleted the browser-monitoriframeforhash-monitorpopupforhash branch October 6, 2021 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
msal@1.x Related to msal@1.x (implicit flow) msal-browser Related to msal-browser package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants