Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instantiate Logger instance for PublicClientApplication #1882

Merged
merged 3 commits into from Jul 2, 2020
Merged

Instantiate Logger instance for PublicClientApplication #1882

merged 3 commits into from Jul 2, 2020

Conversation

jasonnutter
Copy link
Contributor

@jasonnutter jasonnutter commented Jul 2, 2020 •
edited

Adds a private logger instance to PublicClientApplication. Also makes the default loggerCallback a noop, as apps should only get console.logs if they implement them.

@github-actions github-actions bot added the msal-browser Related to msal-browser package label Jul 2, 2020
@coveralls
Copy link

coveralls commented Jul 2, 2020 •
edited

Coverage Status

Coverage decreased (-0.06%) to 80.982% when pulling de4fc0f on browser-pca-logger into fa3c04a on dev.

@github-actions github-actions bot added the samples Related to the samples apps for the library. label Jul 2, 2020
pkanher617
pkanher617 approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@pkanher617 pkanher617 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pkanher617 pkanher617 merged commit 95e76d4 into dev Jul 2, 2020
@pkanher617 pkanher617 deleted the browser-pca-logger branch October 2, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnorling tnorling tnorling approved these changes

@pkanher617 pkanher617 pkanher617 approved these changes

@DarylThayil DarylThayil Awaiting requested review from DarylThayil

@jmckennon jmckennon Awaiting requested review from jmckennon

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

@sameerag sameerag Awaiting requested review from sameerag sameerag is a code owner

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

Assignees

@pkanher617 pkanher617

Labels
msal-browser Related to msal-browser package samples Related to the samples apps for the library.
Projects
None yet
Milestone
@azure/msal-browser@2.0.0 - GA Release
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jasonnutter @coveralls @tnorling @pkanher617