[msal-browser] Move authority initialization from constructor #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkanher617
requested review from
DarylThayil,
jasonnutter,
jmckennon,
jo-arroyo,
sameerag,
hectormmg and
tnorling
as code owners
pkanher617
commented
Jul 2, 2020
Comment on lines
+474
to
+493
| /** | ||
| * | ||
| * Use to get the redirect uri configured in MSAL or null. | ||
| * Evaluates redirectUri if its a function, otherwise simply returns its value. | ||
| * @returns {string} redirect URL | ||
| * | ||
| */ | ||
| private getRedirectUri(requestRedirectUri?: string): string { | ||
| return requestRedirectUri || this.config.auth.redirectUri || BrowserUtils.getCurrentUri(); | ||
| } | ||
|
|
||
| /** | ||
| * Use to get the post logout redirect uri configured in MSAL or null. | ||
| * Evaluates postLogoutredirectUri if its a function, otherwise simply returns its value. | ||
| * | ||
| * @returns {string} post logout redirect URL | ||
| */ | ||
| private getPostLogoutRedirectUri(requestPostLogoutRedirectUri?: string): string { | ||
| return requestPostLogoutRedirectUri || this.config.auth.postLogoutRedirectUri || BrowserUtils.getCurrentUri(); | ||
| } |
There was a problem hiding this comment.
Moved without change
jasonnutter
approved these changes
Jul 2, 2020
tnorling
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the constructor to remove async authority creation and have it occur only on the first API call.