New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0] msal 2.0 supports throttling #1907

Merged

jmckennon merged 34 commits into dev from msal-throttling

Sep 4, 2020

Contributor

jmckennon commented Jul 7, 2020

This PR implements the primary portion of client-side throttling in msal-common. There will be a few accompanying PRs associated with tests and msal-browser.

jmckennon requested review from DarylThayil, jasonnutter, jo-arroyo, pkanher617, sameerag, hectormmg and tnorling as code owners

July 7, 2020 17:52

github-actions bot added the msal-common label

jmckennon commented

View reviewed changes

lib/msal-common/src/network/ThrottlingManager.ts Outdated Show resolved Hide resolved

jmckennon mentioned this pull request

[WIP] msal-common supports throttling based on thumbprints #1338

Closed

pkanher617 reviewed

View reviewed changes

lib/msal-common/src/network/ThrottlingManager.ts Outdated Show resolved Hide resolved

tnorling reviewed

View reviewed changes

lib/msal-common/src/network/RequestThumbprintValue.ts Outdated Show resolved Hide resolved

tnorling reviewed

View reviewed changes

lib/msal-common/src/network/RequestThumbprint.ts Outdated Show resolved Hide resolved

pkanher617 reviewed

View reviewed changes

lib/msal-common/src/client/AuthorizationCodeClient.ts Outdated Show resolved Hide resolved

pkanher617 reviewed

View reviewed changes

lib/msal-common/src/client/BaseClient.ts Outdated Show resolved Hide resolved

tnorling reviewed

View reviewed changes

lib/msal-common/src/network/ThrottlingUtils.ts Outdated Show resolved Hide resolved

tnorling reviewed

View reviewed changes

lib/msal-common/src/utils/StringUtils.ts Outdated Show resolved Hide resolved

tnorling reviewed

View reviewed changes

lib/msal-common/src/network/ThrottlingUtils.ts Outdated Show resolved Hide resolved

tnorling reviewed

View reviewed changes

lib/msal-common/src/utils/Constants.ts Outdated Show resolved Hide resolved

tnorling reviewed

View reviewed changes

lib/msal-common/src/network/ThrottlingUtils.ts Outdated Show resolved Hide resolved

tnorling mentioned this pull request

MSER Telemetry #1908

Closed

1 task

jmckennon force-pushed the msal-throttling branch from 1717218 to 0e5d7ff Compare

July 16, 2020 20:20

github-actions bot added the msal-browser label

jmckennon changed the title ~~[WIP][2.0] msal 2.0 supports throttling~~ [2.0] msal 2.0 supports throttling

jmckennon commented

View reviewed changes

lib/msal-browser/src/cache/BrowserStorage.ts Outdated Show resolved Hide resolved

Contributor

jasonnutter commented Jul 16, 2020

I think we might want to wait for after GA to merge and release this, thoughts @pkanher617? Should add to appropriate milestone.

coveralls commented Jul 16, 2020 •

edited

Coverage increased (+0.2%) to 83.333% when pulling a1f4884 on msal-throttling into f851df6 on dev.

sangonzal approved these changes

View reviewed changes

Contributor

sangonzal left a comment

Looks good

tnorling reviewed

View reviewed changes

Collaborator

tnorling left a comment

Couple comments but overall nice job!

lib/msal-common/src/client/BaseClient.ts Outdated Show resolved Hide resolved

lib/msal-common/src/network/ThrottlingUtils.ts Outdated Show resolved Hide resolved

lib/msal-common/src/network/ThrottlingUtils.ts Show resolved Hide resolved

lib/msal-common/src/utils/Constants.ts Outdated Show resolved Hide resolved

jmckennon force-pushed the msal-throttling branch from f121221 to cfce91d Compare

July 20, 2020 19:19

jmckennon added 23 commits

September 3, 2020 15:06


          Add function comments

02a3ed9


          Fix calculateThrottleTime decimals

d8bf30c


          Add a few unit tests

d8e4690


          Add the rest of ThrottlingUtils tests

b65f625


          Add NetworkManager tests

a819ece


          Fix white space

f37e535


          Add tests constants

29fd838


          Fix lint errors and move types into separate files

b4cb6f9


          Add removeThrottle

2541aed


          Add changes to msal-browser


          Fix export

2b19b2f


          Move constants and add CacheSchemaType to calls

e92e45b


          Fix comments

1a769e1


          Remove headers and pass in clientId to InteractionHandler.handleCodeR…

b9ef0ea

…esponse


          Add CacheSchemaType.THROTTLE

e6c4be9


          Remove extra stringify

06bb893


          Fix tests

b5b72ff


          Resolve rebase MCs

4c3b106


          Change files

91a1dba


          Remove comma and add EOL to test files

3179acf


          Fix MCs

87e1ed2


          Add ThrottlingEntity, delete RequestThumbprintValue

dd09f36


          Add CacheValueType for ThrottlingEntity

a1f4884

jmckennon force-pushed the msal-throttling branch from 5c38cec to a1f4884 Compare

September 3, 2020 22:52

pkanher617 approved these changes

View reviewed changes

jmckennon merged commit 24e7ee9 into dev

jasonnutter added this to the @azure/msal-browser@2.2.0 Release milestone

jasonnutter modified the milestones: @azure/msal-browser@2.3.0 Release, @azure/msal-browser@2.2.0 Release

jmckennon deleted the msal-throttling branch

October 19, 2020 20:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tnorling tnorling approved these changes

pkanher617 pkanher617 approved these changes

sangonzal sangonzal approved these changes

DarylThayil Awaiting requested review from DarylThayil

jasonnutter Awaiting requested review from jasonnutter

jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

sameerag Awaiting requested review from sameerag sameerag is a code owner

hectormmg Awaiting requested review from hectormmg hectormmg is a code owner