[msal-browser] Add platform-level state object to state string and read interaction type #2045
Conversation
github-actions
bot
added
msal-browser
pkanher617
requested review from
DarylThayil,
jasonnutter,
jmckennon,
jo-arroyo,
sameerag,
hectormmg and
tnorling
as code owners
| // Deserialize hash fragment response parameters. | ||
| const hashUrlString: UrlString = new UrlString(hash); | ||
| const serverParams: ServerAuthorizationCodeResponse = hashUrlString.getDeserializedHash<ServerAuthorizationCodeResponse>(); | ||
| const requestStateObj: RequestStateObject = ProtocolUtils.parseRequestState(this.browserCrypto, serverParams.state); |
There was a problem hiding this comment.
Would it make sense to write a helper function that gets the interactionType from state? Is this something we might need to do in other places as well?
There was a problem hiding this comment.
We can extract this in the future if we need it, but for now this is only needed for redirect flows.
| export enum InteractionType { | ||
| REDIRECT = "redirect", | ||
| POPUP = "popup", | ||
| SILENT = "silent" |
There was a problem hiding this comment.
Throttling I believe also has this concept. @jmckennon
|
|
||
| const stateString = JSON.stringify(stateObj); | ||
|
|
||
| return browserCrypto.base64Encode(stateString); |
There was a problem hiding this comment.
I don't think this needs to be encoded here. What about returning the stateObj and then adding that as is to the library state object? That way we are only encoding/stringifying/decoding/parsing once.
There was a problem hiding this comment.
I didn't want common to specify the exact object structure, which is why I made it a string. I felt like adding any type for platformState was too generic. We can talk about this offline.
handleRedirect fixes
pkanher617
modified the milestones:
@azure/msal-browser@2.1.0 Release,
@azure/msal-browser@2.0.1 Release
This PR addresses an issue where the handleRedirectPromise() code would be processed inside a popup before monitorWindowForHash can detect the hash value. This may happen if the opening window's execution is paused or suspended.
I have added the following: