[msal-browser] Fix Promises in PCA APIs #2091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkanher617
requested review from
DarylThayil,
jasonnutter,
jmckennon,
jo-arroyo,
sameerag,
hectormmg and
tnorling
as code owners
pkanher617
changed the title
github-actions
bot
added
msal-browser
jasonnutter
approved these changes
Aug 4, 2020
sameerag
reviewed
Aug 4, 2020
| const hash = await interactionHandler.monitorPopupForHash(popupWindow, this.config.system.windowHashTimeout); | ||
|
|
||
| // Handle response from hash string. | ||
| return await interactionHandler.handleCodeResponse(hash); |
There was a problem hiding this comment.
The catch is a single catch for all issues seen in initialization, creating auth code client and handling the code response. Is that alright?
There was a problem hiding this comment.
Since we cache items in the request preflighting, we need to make sure that we clear it if there are any errors that happen.
There was a problem hiding this comment.
plus cache the error for telemetry purposes. This is done in every API
tnorling
approved these changes
Aug 4, 2020
samples/msal-browser-samples/VanillaJSTestApp2.0/app/default/auth.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where promises were not resolving in silent flow APIs, which wasn't clearing cache correctly. Should also fix #2089.