Separate Cache Lookup and Token Refresh in SilentFlowClient #2189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion-library-for-js into separate-acquireCachedToken-refreshToken
pkanher617
reviewed
Aug 25, 2020
jasonnutter
reviewed
Aug 25, 2020
…tion-library-for-js into separate-acquireCachedToken-refreshToken
…thub.com/AzureAD/microsoft-authentication-library-for-js into separate-acquireCachedToken-refreshToken
tnorling
requested review from
DarylThayil,
jmckennon,
jo-arroyo,
sameerag and
hectormmg
as code owners
pkanher617
approved these changes
Aug 27, 2020
sameerag
reviewed
Aug 27, 2020
| credentialType: CredentialType.ACCESS_TOKEN, | ||
| clientId, | ||
| realm: account.tenantId, | ||
| target: scopes.printScopesLowerCase() |
There was a problem hiding this comment.
We are storing scopes in lower case and look-up in lower case. We need to address this, as I observed in cache-compat test cases, other libraries store the case as is. We may need to talk about this.
My take: Look up should be case insensitive but storing should be as is.
There was a problem hiding this comment.
100% agree. As this PR is scoped to a refactor, let's take functional changes in a follow up PR
sameerag
approved these changes
Aug 27, 2020
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly refactors the SilentFlowClient and provides 2 additional APIs
Changes include:
acquireCachedTokenandrefreshTokenfunction inSilentFlowClientacquireTokenfunction refactored to call the 2 new APIsCacheManagergetCacheRecordfunction toCacheManagerto do all the token cache lookups in one place