Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename TokenCache.cacheHasChanged to TokenCache.hasChanged #2332

Merged
merged 6 commits into from Sep 23, 2020
Merged

Rename TokenCache.cacheHasChanged to TokenCache.hasChanged #2332

merged 6 commits into from Sep 23, 2020

Conversation

sangonzal
Copy link
Contributor

Node TokenCache used to be CacheManager. At that point, CacheManager.cacheHasChanged made sense. Now that it's been updated to TokenCache, TokenCache.cacheHasChanged is a bit redundant. Proposing to update this to TokenCache.hasChanged

@github-actions github-actions bot added the msal-node Related to msal-node package label Sep 22, 2020
@coveralls
Copy link

coveralls commented Sep 22, 2020 •
edited

Coverage Status

Coverage remained the same at 83.344% when pulling 2c5d2f1 on msal-node/token-cache into cf31946 on dev.

@sangonzal sangonzal merged commit e8eed2a into dev Sep 23, 2020
@tnorling tnorling deleted the msal-node/token-cache branch October 6, 2021 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectormmg hectormmg hectormmg approved these changes

@sameerag sameerag sameerag approved these changes

Assignees
No one assigned
Labels
msal-node Related to msal-node package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sangonzal @coveralls @hectormmg @sameerag