Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CDN doc for msal-core #2411

Merged
merged 4 commits into from Oct 14, 2020
Merged

Add CDN doc for msal-core #2411

merged 4 commits into from Oct 14, 2020

Conversation

jasonnutter
Copy link
Contributor

@jasonnutter jasonnutter commented Oct 12, 2020

Adds dedicated document for CDN usage for MSAL.js v1, including updated hashes for 1.4.1.

This will replace this page: https://github.com/AzureAD/microsoft-authentication-library-for-js/wiki/MSAL-JS-CDN-URL-and-SRI-Hash

@github-actions github-actions bot added the msal@1.x Related to msal@1.x (implicit flow) label Oct 12, 2020
@coveralls
Copy link

coveralls commented Oct 12, 2020

Coverage Status

Coverage remained the same at 82.733% when pulling 69b29df on core-cdn-docs into 5227326 on dev.

@jasonnutter jasonnutter added the documentation Related to documentation. label Oct 12, 2020
In addition to npm, `msal` can be consumed from Microsoft-hosted CDNs.

## Best Practices

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A TOC might be useful here since there are a lot of sections.

Copy link
Contributor

@pkanher617 pkanher617 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple suggestions for the doc but otherwise looks good.

@jasonnutter jasonnutter merged commit a0fd4de into dev Oct 14, 2020
@tnorling tnorling deleted the core-cdn-docs branch October 6, 2021 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation. msal@1.x Related to msal@1.x (implicit flow)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants