Expose idTokenClaims on AccountInfo #2554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonnutter
requested review from
jmckennon,
pkanher617,
sameerag and
tnorling
as code owners
github-actions
bot
added
msal-browser
5 tasks
jasonnutter
commented
Nov 6, 2020
jasonnutter
commented
Nov 6, 2020
sameerag
reviewed
Nov 6, 2020
pkanher617
modified the milestones:
@azure/msal-browser@2.5.3 Release,
@azure/msal-browser@2.6.1 Release
tnorling
modified the milestones:
@azure/msal-browser@2.6.1 Release,
@azure/msal-browser@2.7.0,
@azure/msal-browser@2.8.0
|
This PR has not seen activity in 14 days. It may be closed if it remains stale. |
|
When is this PR going to be completed? |
…rary-for-js into browser-idtokenclaims-accountinfo
jasonnutter
modified the milestones:
@azure/msal-browser@2.8.0,
@azure/msal-common@2.0.0
hectormmg
approved these changes
Dec 2, 2020
Looking to have it merged soon and included in |
jo-arroyo
approved these changes
Dec 2, 2020
change/@azure-msal-browser-2020-12-01-17-42-10-browser-idtokenclaims-accountinfo.json
Outdated
Show resolved
Hide resolved
change/@azure-msal-common-2020-12-01-17-42-10-browser-idtokenclaims-accountinfo.json
Outdated
Show resolved
Hide resolved
change/@azure-msal-node-2020-12-01-17-42-10-browser-idtokenclaims-accountinfo.json
Outdated
Show resolved
Hide resolved
…claims-accountinfo.json Co-authored-by: Jo Arroyo <joarroyo@microsoft.com>
Co-authored-by: Jo Arroyo <joarroyo@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
AccountEntityobjects and ID tokens are cached separately, when buildingAccountInfoobjects we will need to look up the ID token for the given account, decode it, and attach it to the returned object. Should work for browser and Node since all the changes are done in common.