msal-browser testing sample using msal-node to obtain tokens #2771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnorling
requested review from
hectormmg,
jmckennon,
pkanher617 and
sameerag
as code owners
github-actions
bot
added
msal-node
7 tasks
jasonnutter
reviewed
Dec 17, 2020
| @@ -88,6 +88,10 @@ export class TokenCache implements ISerializableTokenCache { | |||
| } | |||
| } | |||
|
|
|||
| getKVStore(): CacheKVStore { | |||
There was a problem hiding this comment.
Do you think we should add tests for this?
jasonnutter
approved these changes
Dec 17, 2020
sameerag
reviewed
Dec 17, 2020
I agree, I think we should make it clear that this should only be done for tests, not in a production app. |
I also agree. I've added a warning to the top of the sample readme |
|
This PR has not seen activity in 14 days. It may be closed if it remains stale. |
pkanher617
approved these changes
Jan 4, 2021
sameerag
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPAs using
msal-browserto obtain tokens don't have an easy way to test their protected pages or APIs without using something like puppeteer to navigate through the AAD sign-in pages. This PR demonstrates how someone could use msal-node's ROPC flow to obtain tokens on the backend and pre-populate local/session storage with tokens.One new API is exposed on the msal-node
TokenCacheto retrieve the Key Value store to make this easier.