Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[msal-angular] Guard supports angular routes for login failure #2803

Merged
merged 12 commits into from Jan 11, 2021
Merged

[msal-angular] Guard supports angular routes for login failure #2803

merged 12 commits into from Jan 11, 2021

Conversation

jo-arroyo
Copy link
Collaborator

@jo-arroyo jo-arroyo commented Dec 21, 2020 •
edited

This PR:

  • Adds loginFailedRoute to msal.guard.config
  • Adds check for loginFailedRoute in Guard, and redirects to loginFailedRoute on login failure if set
  • Adds failed component to angular 11 sample to demonstrate use of loginFailedRoute
  • Adds unit tests for change
  • Updates configuration docs and upgrade guide docs

This PR addresses concerns raised in #703 and #1593.

@jo-arroyo
Add loginFailedRoute to guard config, update guard to redirect to log…
853b322 
…inFailedRoute on login failure, update angular11 sample to demonstrate loginFailedRoute
@github-actions github-actions bot added msal-angular Related to @azure/msal-angular package samples Related to the samples apps for the library. labels Dec 21, 2020
@coveralls
Copy link

coveralls commented Dec 21, 2020 •
edited

Coverage Status

Coverage increased (+0.02%) to 81.88% when pulling 4acb0dc on guard-access-denied into c68ac59 on dev.

@jo-arroyo jo-arroyo marked this pull request as ready for review December 22, 2020 23:20
@jo-arroyo jo-arroyo merged commit 72b8e06 into dev Jan 11, 2021
@jo-arroyo jo-arroyo deleted the guard-access-denied branch January 11, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonnutter jasonnutter jasonnutter approved these changes

@tnorling tnorling tnorling approved these changes

@DarylThayil DarylThayil Awaiting requested review from DarylThayil

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

@jmckennon jmckennon Awaiting requested review from jmckennon

@pkanher617 pkanher617 Awaiting requested review from pkanher617

@sameerag sameerag Awaiting requested review from sameerag sameerag is a code owner

Assignees
No one assigned
Labels
msal-angular Related to @azure/msal-angular package samples Related to the samples apps for the library.
Projects
None yet
Milestone
@azure/msal-angular@2.0.0-alpha.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jo-arroyo @coveralls @jasonnutter @tnorling