Provide a way for developers to override the navigation methods used #2985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
github-actions
bot
added
msal-browser
tnorling
modified the milestones:
@azure/msal-angular@2.0.0-beta.0,
@azure/msal-react@1.0.0-beta.0
tnorling
modified the milestones:
@azure/msal-react@1.0.0-alpha.5,
@azure/msal-react@1.0.0-beta.0
…tion-library-for-js into client-side-navigation
tnorling
requested review from
jasonnutter,
jo-arroyo,
pkanher617 and
sameerag
as code owners
jasonnutter
reviewed
Feb 10, 2021
jasonnutter
reviewed
Feb 10, 2021
pkanher617
reviewed
Feb 18, 2021
tnorling
commented
Feb 18, 2021
change/@azure-msal-browser-58ddbcda-5d34-4249-acbd-c5e52b1d8144.json
Outdated
Show resolved
Hide resolved
tnorling
changed the title
…icrosoft-authentication-library-for-js into client-side-navigation
jo-arroyo
approved these changes
Feb 19, 2021
samples/msal-react-samples/gatsby-sample/src/wrap-with-provider.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Jo Arroyo <joarroyo@microsoft.com>
…tion-library-for-js into client-side-navigation
tnorling
modified the milestones:
@azure/msal-react@1.0.0-beta.0,
@azure/msal-browser@2.12.0
…tion-library-for-js into client-side-navigation
pkanher617
reviewed
Feb 25, 2021
pkanher617
reviewed
Feb 25, 2021
pkanher617
reviewed
Feb 25, 2021
pkanher617
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context/Motivation: React routers, such as
react-router-domornext/routerprovide the ability to do "client side routing" using the HTML5 History API which essentially means that you can navigate to other "pages" in your app without doing a hard redirect and reloading the entire webpage. In Angular you can use the built-in router to do this by callingRouter.navigateByUrl()Behavior Now: When using the redirect flow msal will attempt to send you back to the page you started on by reassigning
window.location. This causes the whole SPA to reload and you gain no performance benefit from using a router.Proposed Change: This PR removes the
navigateWindowAPI and replaces it with aNavigationClientinterface which the developer can override by providing their own implementations ofnavigateInternaland/ornavigateExternal. Also adds asetNavigationClientAPI developers can use to set theNavigationClientafter initializingPublicClientApplication(needed for react and angular)Addresses #2869
Follow up enhancements: