Add logs to msal-browser #3004
Merged
Add logs to msal-browser #3004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jo-arroyo
requested review from
jasonnutter,
pkanher617 and
tnorling
as code owners
tnorling
approved these changes
Mar 1, 2021
change/@azure-msal-browser-3e900bbd-5fb6-4800-9cf5-beeaefbc5e47.json
Outdated
Show resolved
Hide resolved
| @@ -288,6 +295,7 @@ export class BrowserCacheManager extends CacheManager { | |||
| * @param appMetadataKey | |||
| */ | |||
| getAppMetadata(appMetadataKey: string): AppMetadataEntity | null { | |||
| this.logger.verbose("BrowserCacheManager.getAppMetadata called"); | |||
| const value = this.getItem(appMetadataKey); | |||
| if (!value) { | |||
| return null; | |||
There was a problem hiding this comment.
In each of the getters should we also log whether or not we successfully found something in the cache?
There was a problem hiding this comment.
Makes sense. I added cache hit logs, and it makes the logs a lot longer. If we discover it creates too much noise, I'm happy to remove them later.
…7.json Co-authored-by: Thomas Norling <thomas.l.norling@gmail.com>
pkanher617
approved these changes
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: