Add logoutPopup API #3044
Merged
Add logoutPopup API #3044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
msal-browser
5 tasks
jasonnutter
reviewed
Mar 3, 2021
tnorling
requested review from
pkanher617,
sameerag and
samuelkubai
as code owners
26 tasks
jasonnutter
reviewed
Mar 18, 2021
jasonnutter
reviewed
Mar 18, 2021
jasonnutter
reviewed
Mar 18, 2021
jo-arroyo
reviewed
Mar 18, 2021
jasonnutter
reviewed
Mar 23, 2021
jasonnutter
reviewed
Mar 23, 2021
jo-arroyo
approved these changes
Mar 23, 2021
jasonnutter
approved these changes
Mar 23, 2021
Angular E2E tests are still running on published versions of the lib afaik so it is expected that they fail on this PR. This is something we need to fix before GA cc: @jo-arroyo |
10 tasks
10 tasks
| @@ -11,5 +11,6 @@ The MSAL Browser library has a set of configuration options that can be used to | |||
| | `acquireTokenSilent` | [SilentRequest](https://azuread.github.io/microsoft-authentication-library-for-js/ref/modules/_azure_msal_browser.html#silentrequest) | [AuthenticationResult](https://azuread.github.io/microsoft-authentication-library-for-js/ref/modules/_azure_msal_browser.html#authenticationresult) | | |||
| | `loginPopup` | [PopupRequest](https://azuread.github.io/microsoft-authentication-library-for-js/ref/modules/_azure_msal_browser.html#popuprequest) | [AuthenticationResult](https://azuread.github.io/microsoft-authentication-library-for-js/ref/modules/_azure_msal_browser.html#authenticationresult) | | |||
| | `loginRedirect` | [RedirectRequest](https://azuread.github.io/microsoft-authentication-library-for-js/ref/modules/_azure_msal_browser.html#redirectrequest) | [AuthenticationResult](https://azuread.github.io/microsoft-authentication-library-for-js/ref/modules/_azure_msal_browser.html#authenticationresult) (via `handleRedirectPromise`) | | |||
| | `logout` | [EndSessionRequest](https://azuread.github.io/microsoft-authentication-library-for-js/ref/modules/_azure_msal_browser.html#endsessionrequest) | `void` | | |||
There was a problem hiding this comment.
This is technically a new major version. Assuming you're going with semver that is.
There was a problem hiding this comment.
Yes you're right that this would be a breaking change, however, the logout API has not been removed from the library, just from the docs (to encourage people to use the new APIs going forward). This API will be removed in the next major version
pkanher617
pushed a commit
to pkanher617/microsoft-authentication-library-for-js
that referenced
this pull request
Dec 30, 2021
Add logoutPopup API
azure-pipelines bot
pushed a commit
to pkanher617/microsoft-authentication-library-for-js
that referenced
this pull request
Jan 4, 2022
Add logoutPopup API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
logoutPopupAPI as described in the design proposal: #3123