Ignore account hints when prompt=select_account

[tnorling]

AAD throws an error when you pass both prompt=select_account and a login_hint or sid as these are conflicting. This becomes problematic when someone wants to use prompt=select_account to switch users and has previously used the setActiveAccount API in browser (we quietly pass down the active account if none is provided to the interactive API).

This PR ignores account hints if prompt=select_account to prevent this error from happening unexpectedly.

[coveralls]

Coverage remained the same at 83.575% when pulling 757f87e on ignore-account-hints into 20779b8 on dev.

[jasonnutter]

One question otherwise looks good!

[sameerag]

The server mandates that sid/login_hint should be used only for prompt=none use cases. Did we remove that check?

[tnorling]

The server mandates that sid/login_hint should be used only for prompt=none use cases. Did we remove that check?

AFAIK this was never present in 2.x. This PR only sends sid when prompt=none, however, login_hint is valid for prompt=login so will only be ignored if prompt=select_account.

[sameerag]

Approved. One thing: test cases to ignore sid for prompt!=none (if user provides it), please check that once.

[tnorling]

Approved. One thing: test cases to ignore sid for prompt!=none (if user provides it), please check that once.

Yes, it's there (test cases to use login_hint over sid if prompt != none covers this as login_hint has lower priority than sid)

[sameerag]

Yes, it's there (test cases to use login_hint over sid if prompt != none covers this as login_hint has lower priority than sid)

I don't think we are testing this use case: Only sid and ignoring it if passed with prompt != none. This is different from making sid lower priority. Not blocking this PR, but this test case is critical to have around, in case something changes tomorrow.

[tnorling]

Yes, it's there (test cases to use login_hint over sid if prompt != none covers this as login_hint has lower priority than sid)

I don't think we are testing this use case: Only sid and ignoring it if passed with prompt != none. This is different from making sid lower priority. Not blocking this PR, but this test case is critical to have around, in case something changes tomorrow.

Gotcha, added!