-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix /consumers authority caching #3327
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectormmg
approved these changes
Mar 29, 2021
jasonnutter
approved these changes
Mar 30, 2021
sameerag
approved these changes
Mar 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. Approving this for now. I remember there is an MSA passthru use case that needs to be tested here, I will reach out with details. We can unblock this PR but lets follow through.
…ithub.com/AzureAD/microsoft-authentication-library-for-js into fix-token-caching-for-consumers-authority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last year we made a change to ensure
/organizations
and/common
authority are cached with the tenantId and don't result in cache misses when the tenantId is not explicitly provided. We missed the/consumers
authority which is now potentially leaving the cache in a state that contains both/consumers
and a tenanted authority for the same set of scopes and throws a multiple authority error.Also removes multiple authority error which is no longer doing what it was originally intended to do (throw when multiple cache entries existed for the same scope but different authorities). If a cache entry is not found for the provided scopes and authority it should result in a cache miss regardless of what other tokens are available in the cache.