Preserve ES modules and enable treeshaking #3563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…this makes the tree shaking work
…fig.js. this makes the tree shaking work" This reverts commit cc4b469.
…es instead of bundling, and add sideEffects: false to enable tree-shaking. So far, I've just commented out the other builds to test, and tree-shaking from the consumer now works!
…msal-browser Make msal-browser and msal-common package preservedModules and mark sideEffects: false to enable tree-shaking for consumer
github-actions
bot
added
msal-browser
jasonnutter
reviewed
Apr 30, 2021
jasonnutter
approved these changes
May 10, 2021
Closed
10 tasks
pkanher617
approved these changes
May 10, 2021
pkanher617
pushed a commit
to pkanher617/microsoft-authentication-library-for-js
that referenced
this pull request
Dec 30, 2021
Preserve ES modules and enable treeshaking
azure-pipelines bot
pushed a commit
to pkanher617/microsoft-authentication-library-for-js
that referenced
this pull request
Jan 4, 2022
Preserve ES modules and enable treeshaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes several changes to the rollup configs for
msal-commonandmsal-browser:msal-browserdoes not bundlemsal-commonwith the es module buildmsal-commonUMD bundle generation as we don't upload to CDNDependency updates:
rollupto version 2rollup-plugin-node-resolvepackage with@rollup/plugin-node-resolverollup-plugin-jsonas it's no longer neededThis is a first step towards reducing bundle size. Next step is to refactor some of our code to make it possible to be treeshaked.